Review: Unit testing Fail Report

I run test on master branch: master_withoutDCS. I found out some fail test.

Can reproduce npm run test.

Can someone confirm this and what type of action should be take to fix these fix?

@SysAdmin @tmcnulty?

I can try to get these test to pass if I can. If I can fix some of the error. I might create branch to work from master branch.

Sorry @vutran I forgot to follow this up. I’ll DM Tom and see if he can head over to answer.

Hey @vutran

Our tests have been neglected for a long time, if you can get them fixed that’d be a great help, as it’s preventing me from adding testing to the build process.

It’s same to assume that any failed test should be fixed, and if you find while fixing it that it’s no longer an applicable test, either removing it or adjusting it would be great too.

Thanks

11080×790 38.9 KB

I was able to fix some test that was fail to pass. I am not sure error abour Meteor is not defined almost all the test suites.I try to reinstall npm if will help install Meteor. No go. I will continue to research on this issue.

For now I create a branch call: unit_testing_branch. I submit PR request. @AndyatFocallocal

@vutran merged. well done!

21366×550 33.8 KB

31272×510 50.3 KB

I think I solve the mystery of Meteor not defined in these all test.

It seen it was missing the settings.json setting to set i18n content when we change somewhere.

Now all test is running now with Meteor…

So I will continuous to fix these and work on my branch: unit_testing_branch