Replace cardlink with react link component
@Marvelxy Can you have a look at the code again as Travis failed to build it so i think thereās an error somewhere.
Howās the search bar and stats button coming?
I will take a look.
Well, Iāve not made much progress yet. For the search, I wanted to use a react package, but I couldnāt use it because of the version of our project. Iām currently building the package as a component, but Iāve paused it to fix the bugs you reported.
1 Like
It would be good to update React. Tom has looked into it but hit some issues, i think its tricky
The travis build issues doesnāt look like my changes are the cause.
I see build errors from previous merge requests:
I thought you said the build usually fail?
I accidentally update the fl-maps branch instead of Master and Travis decided to build that branch and now wonāt build Master anymore.
Iām really not sure whats going on, i think maybe both are hooked up to the live site and the latest one to build is the one that shows. Iāve asked Tom if he cans see whatās going on
I was going to pull Master downstream to fl-maps but it wants to change a whole lot of files. I think i should do it anyway and see whether it works or not, as it should be pretty easy to revert if it doesnāt work.
Just hunting for an error in the whitepaper which iāve been updating today and is being flagged. Then iāll complete the downstream PR
@Marvelxy ok that fixed it and the live branch is now phm-deploy (though it also shows as failed now in Travis which will need looking into by the @SysAdmin team).
Your update also went live although the platform is now using a different system for urls which doesnāt appear to be set up correctly. You can recreate by clicking any of the links on the homepage.
1 Like
I have an idea iām checking out for why they arenāt working anymore related to this page fl-maps/dcs-website.json at master Ā· focallocal/fl-maps Ā· GitHub
Itāll be about 20mins before we know as it needs to update master and then i can pull it to phm branchā¦ or maybe iāll just copy paste it in now to halve the wait
Looks like the href links are the next options if you ask me.
can you expand that a bit?
I changed the links back the the href=ālinkā version, they seem to work.
1 Like
Not opening a window inside a window so we have two headers again?
Itās supposed to just redirect to the link. I actually didnāt test properly on Discuss before making the changes.
My changes didnāt act as expected. Do you want to make a PR with the reverted urls and see if that fixes it?
Okay, i will do a revert.
1 Like
it should be quick, Iām still awake. We can test it to see if it works.
1 Like