Upgrade React to 16.8+ version

Ah, that makes sense. I remember setting up font awesome myself here and on our old wordpress platform and it was a bit twitchy between versions. Great that you found it, and that it isn’t a more worrying issue :slightly_smiling_face:

Let me know if you are able to find a fix and make a PR for it.

I created a PR(I didn’t fix everything, but the ones I can see right now from menu bar and side bar):

Now I can see that when I clicked on login, it directed me to sign in with discourse, then returned to my local. That is interesting. I need to study the code some more.

Also I found that there’s some issues with uniforms module, and I cannot load the form. I think this is related to meteor upgrades. Since I was going to look at form stuff, and uniforms module need to be updated anyways, I can try fix it next.(either with react upgrade, or not)

1 Like

You should be able to hook them together with an api following this guide

1 Like

Yes, i’m glad you’re here. I was concerned we’d struggle with broken modules after the upgrade, but there was a quite a few people helping out so i thought we’d be ok. They dropped off immediately after the push so getting our platform building and running again is definitely a big issue.

I hope I can help :slight_smile:

I am currently experimenting with the form stuff. I am going to stick with uniforms library for now since it supports simple schema, which is used in meteor apps. But we do need to upgrade it, along with other necessary modules.

To get the form working, I probably need to make lots of changes to the code base, as the form and schema tied to database operations. I am learning meteor and uniforms while working on this, so I would use new features and recommended ways to do things.(decipher the old not maintained code is not easy…)

My plan is to at least get the form showing up and functioning first, then we can make other changes to it. I would put my code in the separate branch until then. What do you think? I will let you know my progress, and any issues I encounter.

One thing I want to ask is, do we need to worry much about the existing data if we have any schema migration?

1 Like

I would put my code in the separate branch

Sure. Although none of the branches are building now so if you think it might take a while you might as well put it into the main branch so others are less likely to make changes which conflict with yours

One thing I want to ask is, do we need to worry much about the existing data if we have any schema migration?

It would be nice to keep the data on Brighter Tomorrow Map as that has some resources posted into it. Perhaps pull it out into a CSV and I’ll Google for any missing data and add it.

1 Like

Okay sounds good. I will merge small stuff in master gradually and make sure at least the app can be started locally.

I just create another PR: Upgrades and package clean up by zhna123 · Pull Request #1173 · focallocal/fl-maps · GitHub
Let me know if there’s any concern or question.

1 Like

@AndyatFocallocal Just had another idea… I fixed the error(mup-secret.js file cant be found…) locally by making deployment folder hidden.
So I made another pull request to give it another try :slight_smile:

1 Like

Awesome, let’s try it out

@zhna123 Wow!

We have success!! Partly anyway. The good news, its back to building PHM again. The less good news, the Local side isn’t loading anymore so we’re going to look at whats preventing that. Pretty good news is now we can see the error codes in the browser which should help narrow down the culprits.

?key=AIzaSyCuiq_ahPzWE02eCsyaquoVABPUGszpLGM&v=3.exp&libraries=places:303 Google Maps JavaScript API has been loaded directly without a callback. This is not supported and can lead to race conditions and suboptimal performance. For supported loading patterns please see https://goo.gle/js-api-loading

Rea @ js?
key=AIzaSyCuiq_ahPzWE02eCsyaquoVABPUGszpLGM&v=3.exp&libraries=places:303
30760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66 

Error: Minified React error #130; visit https://reactjs.org/docs/error-decoder.html?invariant=130&args[]=undefined&args[]= for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
    at ll (760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:110571)
    at d (760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:53701)
    at m (760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:54981)
    at 760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:57048
    at Qa (760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:66521)
    at _s (760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:106444)
    at Us (760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:97544)
    at Bs (760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:97469)
    at Ls (760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:94394)
    at 760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:46058
xc @ 760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66
760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66 Uncaught 

Error: Minified React error #130; visit https://reactjs.org/docs/error-decoder.html?invariant=130&args[]=undefined&args[]= for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
    at ll (760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:110571)
    at d (760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:53701)
    at m (760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:54981)
    at 760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:57048
    at Qa (760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:66521)
    at _s (760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:106444)
    at Us (760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:97544)
    at Bs (760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:97469)
    at Ls (760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:94394)
    at 760acb9474f1a054fad50b1c518ba746a7f8f7f2.js?meteor_js_resource=true:66:46058

maps.googleapis.com/maps/api/mapsjs/gen_204?csp_test=true:1     Failed to load resource: net::ERR_BLOCKED_BY_CLIENT

@Marvelxy @tmcnulty i thought you’d enjoy seeing that we’re loading again! :slightly_smiling_face:

1 Like

Great! The current issue is likely due to the reactstrap version upgrade I just made. There were components got removed from earlier versions. This error is caused by ListGroup used in the map filter. I can comment out the removed component, and the map page will show up. However, I don’t know what the filter looked like before… I hope any of you have a screenshot or something. Or I can try figure it out later and rebuild the list.

Another issue is the 2 links(Global & Local) on the home page. I am not sure why the url is wrong now. It might be because we are using the Link component instead of a href for an external link. I wonder if we should just change it to a href? I don’t see why we need to use Link, except for running locally.

If you prefer to have the local page at least show up for now, I can assemble a PR to see if it will actually fix the issue - just let me know.

1 Like

I hope any of you have a screenshot or something. Or I can try figure it out later and rebuild the list.

Brightertomorrowmap.com is pretty far behind, but most things are the same.

I’ll have to look at the URLs tomorrow. I remember something but not clearly

That’s awesome! Weldone @zhna123

1 Like